conditionally add to hudstring, remove unneeded patch #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will be merged in next next release lol |
|
ye too late for 5.0.4 lol |
…nto Hide-options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr adds a couple new arguments for the customoption class's constructors and a new method so that settings can be conditionally shown in the settings hudstring. Theres not much not need to show a role's setting if it isnt on and reduces the need for scrolling as much.
1 patch has been removed as it would only run when vanilla settings were changed but it would sync modded options, this is somewhat of a waste and unneeded, and it takes longer for the vanilla setting to change on screen.